Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slug to follow owner_name/repo_name format #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix slug to follow owner_name/repo_name format #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/bitbucket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module.exports = {
build: env.BITBUCKET_BUILD_NUMBER,
buildUrl: `https://bitbucket.org/${env.BITBUCKET_REPO_SLUG}/addon/pipelines/home#!/results/${env.BITBUCKET_BUILD_NUMBER}`,
branch: env.BITBUCKET_BRANCH,
slug: env.BITBUCKET_REPO_SLUG,
slug: env.BITBUCKET_REPO_FULL_NAME,
Comment on lines 14 to +16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you still use BITBUCKET_REPO_SLUG in line 14, is that intentional?

Given that the issue at #136 didn't have any 👍🏼 and no other issues have been opened, I wonder if this is a non-issue?

root: env.BITBUCKET_CLONE_DIR,
};
},
Expand Down