Static height for project Grid
#471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedoor
reviewed
Dec 12, 2023
Switched to Draft until we got feedbacks from designers |
Bumped into the Screencast.from.12-12-2023.14.46.45.webm |
|
Hey! @0xjei thanks, I like this new way. |
cedoor
approved these changes
Dec 12, 2023
Okay, ready! |
cedoor
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevent the grid from floating up when the number of projects per page on the grid is less than the maximum, a static grid and grid item height can help prevent this behaviour.
Related Issue
See #447
Does this introduce a breaking change?
Other information
Screencast.from.12-12-2023.00.26.20.webm