update django use-none-for-password-default rule (#3254)

* update django use-none-for-password-default rule * Update use-none-for-password-default.py * also add new testcase to the expected outcome of applying the autofix --------- Co-authored-by: Pieter De Cremer <[email protected]>
semgrep · Jan 2, 2024 · ca65412 · ca65412
1 parent 1e01ba9
commit ca65412
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/python/django/security/passwords/use-none-for-password-default.fixed.py b/python/django/security/passwords/use-none-for-password-default.fixed.py
@@ -79,3 +79,7 @@ def create_user(self, email, password=None):
         user.set_password(password)
         user.save(using=self._db)
         return user
+
+# ok: use-none-for-password-default
+def foo2(password="helloworld"):
+	model.set_password(password)
diff --git a/python/django/security/passwords/use-none-for-password-default.py b/python/django/security/passwords/use-none-for-password-default.py
@@ -79,3 +79,7 @@ def create_user(self, email, password=""):
         user.set_password(password)
         user.save(using=self._db)
         return user
+
+# ok: use-none-for-password-default
+def foo2(password="helloworld"):
+	model.set_password(password)
diff --git a/python/django/security/passwords/use-none-for-password-default.yaml b/python/django/security/passwords/use-none-for-password-default.yaml
@@ -33,6 +33,9 @@ rules:
             def $F(..., $VAR=$EMPTY, ...):
               ...
               $MODEL.set_password($VAR)
+    - metavariable-pattern:
+        metavariable: $EMPTY
+        pattern: '""'
     - focus-metavariable: $EMPTY
   fix: |
     None