Aggregator service #71

aasseman · 2023-04-28T20:46:14Z

No description provided.

Signed-off-by: Alexis Asseman <[email protected]>

ColePBryan

Looks really good! Just some minor tweaks and pedantic comments. I think I found some comments for my own code while reviewing this, so there might be a little hypocrisy to this review. 😬

tap_aggregator/Cargo.toml

tap_aggregator/src/aggregator.rs

tap_aggregator/src/server.rs

tap_aggregator/src/aggregator.rs

tap_aggregator/src/main.rs

tap_aggregator/src/server.rs

Signed-off-by: Alexis Asseman <[email protected]>

aasseman · 2023-05-02T00:38:27Z

I added a verify() to EIP712SignedMessage:
e389d5c a7e3e7d

Signed-off-by: Alexis Asseman <[email protected]>

github-actions · 2023-05-02T00:47:06Z

Coverage after merging aggregator_service into main will be

83.55%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
tap_aggregator/src
aggregator.rs	85.84%	100%	100%	82.98%	23–26, 33–36, 47–50, 60–63
main.rs	5.56%	100%	11.11%	3.70%	13–15, 17, 21–22, 25–27, 30, 33–38, 41–45, 47, 9
server.rs	90.48%	100%	100%	87.50%	48–52, 65
tap_core/src
eip_712_signed_message.rs	83.78%	100%	80%	85.19%	56
lib.rs	87.50%	100%	87.50%	87.50%	17
receipt_aggregate_voucher.rs	92.11%	100%	85.71%	93.55%	21
tap_core/src/adapters/test
collateral_adapter_mock.rs	82.98%	100%	71.43%	85%	25–26, 44, 50–52
collateral_adapter_test.rs	100%	100%	100%	100%
rav_storage_adapter_mock.rs	94.74%	100%	83.33%	96.88%	7
rav_storage_adapter_test.rs	100%	100%	100%	100%
receipt_checks_adapter_mock.rs	87.18%	100%	83.33%	87.88%	49, 53–55
receipt_checks_adapter_test.rs	95.83%	100%	100%	95%	53
receipt_storage_adapter_mock.rs	97.37%	100%	92.31%	98.41%	7
receipt_storage_adapter_test.rs	100%	100%	100%	100%
tap_core/src/tap_receipt
mod.rs	66.67%	100%	50%	75%
receipt.rs	79.41%	100%	77.78%	80%	20, 44
received_receipt.rs	82.42%	100%	75.86%	83.82%	100–102, 109–111, 113–115, 160, 171, 185–187, 95–97

Emitting ethers_core::types::SignatureError::VerificationError instead of tap_core::Error::InvalidCheckError during signature checks. Signed-off-by: Alexis Asseman <[email protected]>

github-actions · 2023-05-02T01:01:42Z

Coverage after merging aggregator_service into main will be

84.67%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
tap_aggregator/src
aggregator.rs	92.45%	100%	100%	90.70%	37–40, 50–53
main.rs	5.56%	100%	11.11%	3.70%	13–15, 17, 21–22, 25–27, 30, 33–38, 41–45, 47, 9
server.rs	90.48%	100%	100%	87.50%	48–52, 65
tap_core/src
eip_712_signed_message.rs	83.78%	100%	80%	85.19%	56
lib.rs	87.50%	100%	87.50%	87.50%	17
receipt_aggregate_voucher.rs	92.11%	100%	85.71%	93.55%	21
tap_core/src/adapters/test
collateral_adapter_mock.rs	82.98%	100%	71.43%	85%	25–26, 44, 50–52
collateral_adapter_test.rs	100%	100%	100%	100%
rav_storage_adapter_mock.rs	94.74%	100%	83.33%	96.88%	7
rav_storage_adapter_test.rs	100%	100%	100%	100%
receipt_checks_adapter_mock.rs	87.18%	100%	83.33%	87.88%	49, 53–55
receipt_checks_adapter_test.rs	95.83%	100%	100%	95%	53
receipt_storage_adapter_mock.rs	97.37%	100%	92.31%	98.41%	7
receipt_storage_adapter_test.rs	100%	100%	100%	100%
tap_core/src/tap_receipt
mod.rs	66.67%	100%	50%	75%
receipt.rs	79.41%	100%	77.78%	80%	20, 44
received_receipt.rs	82.42%	100%	75.86%	83.82%	100–102, 109–111, 113–115, 160, 171, 185–187, 95–97

Signed-off-by: Alexis Asseman <[email protected]>

github-actions · 2023-05-02T18:49:24Z

Coverage after merging aggregator_service into main will be

84.69%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
tap_aggregator/src
aggregator.rs	92.45%	100%	100%	90.70%	40–43, 53–56
main.rs	5.56%	100%	11.11%	3.70%	12, 16–18, 20, 24–25, 28–30, 33, 36–41, 44–48, 50
server.rs	90.63%	100%	100%	87.76%	51–55, 68
tap_core/src
eip_712_signed_message.rs	83.78%	100%	80%	85.19%	56
lib.rs	87.50%	100%	87.50%	87.50%	17
receipt_aggregate_voucher.rs	92.11%	100%	85.71%	93.55%	21
tap_core/src/adapters/test
collateral_adapter_mock.rs	82.98%	100%	71.43%	85%	25–26, 44, 50–52
collateral_adapter_test.rs	100%	100%	100%	100%
rav_storage_adapter_mock.rs	94.74%	100%	83.33%	96.88%	7
rav_storage_adapter_test.rs	100%	100%	100%	100%
receipt_checks_adapter_mock.rs	87.18%	100%	83.33%	87.88%	49, 53–55
receipt_checks_adapter_test.rs	95.83%	100%	100%	95%	53
receipt_storage_adapter_mock.rs	97.37%	100%	92.31%	98.41%	7
receipt_storage_adapter_test.rs	100%	100%	100%	100%
tap_core/src/tap_receipt
mod.rs	66.67%	100%	50%	75%
receipt.rs	79.41%	100%	77.78%	80%	20, 44
received_receipt.rs	82.42%	100%	75.86%	83.82%	100–102, 109–111, 113–115, 160, 171, 185–187, 95–97

aasseman added 2 commits April 28, 2023 13:44

feat: add aggregator service

26e51a1

Signed-off-by: Alexis Asseman <[email protected]>

refactor: adapt to #63 and #69

393eea1

Signed-off-by: Alexis Asseman <[email protected]>

aasseman added this to the Implement initial TAP prototype milestone Apr 28, 2023

ColePBryan suggested changes Apr 29, 2023

View reviewed changes

refactor(aggregator): remove useless dependencies

cd65c7d

Signed-off-by: Alexis Asseman <[email protected]>

aasseman force-pushed the aggregator_service branch from fa72dbd to cd65c7d Compare May 1, 2023 20:54

aasseman added 8 commits May 1, 2023 14:16

style(aggregator): fix imports

18013ab

Signed-off-by: Alexis Asseman <[email protected]>

style: cleanup Cargo.toml files

b8dc4b9

Signed-off-by: Alexis Asseman <[email protected]>

style(aggregator): fix comment typo

9973507

Signed-off-by: Alexis Asseman <[email protected]>

fix(aggregator): previous_rav ownership

b422504

Signed-off-by: Alexis Asseman <[email protected]>

docs(aggregator): Add description for args help

dbeea05

Signed-off-by: Alexis Asseman <[email protected]>

refactor(aggregator): Remove useless dependency

0a1518a

Signed-off-by: Alexis Asseman <[email protected]>

test(aggregator): replace unwrap w/ assert in protocol_version

10f63e6

Signed-off-by: Alexis Asseman <[email protected]>

docs(core): fix recover_signer docstring

e389d5c

Signed-off-by: Alexis Asseman <[email protected]>

feat(core): add verify to EIP712 signed msg

a7e3e7d

Signed-off-by: Alexis Asseman <[email protected]>

aasseman force-pushed the aggregator_service branch from 2e73e25 to a7e3e7d Compare May 2, 2023 00:39

semiotic-ai deleted a comment from github-actions bot May 2, 2023

fix(aggregator): signature errors

d29d2df

Emitting ethers_core::types::SignatureError::VerificationError instead of tap_core::Error::InvalidCheckError during signature checks. Signed-off-by: Alexis Asseman <[email protected]>

aasseman added 2 commits May 2, 2023 11:06

chore(aggregator): Fix license headers

21bf26b

Signed-off-by: Alexis Asseman <[email protected]>

docs(aggregator): Add TODO for api_version

28607cc

Signed-off-by: Alexis Asseman <[email protected]>

ColePBryan approved these changes May 2, 2023

View reviewed changes

aasseman marked this pull request as ready for review May 2, 2023 19:04

aasseman requested review from severiano-sisneros and tkornuta-semiotic as code owners May 2, 2023 19:04

aasseman merged commit c83fcec into main May 2, 2023

aasseman deleted the aggregator_service branch May 2, 2023 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aggregator service #71

Aggregator service #71

aasseman commented Apr 28, 2023

ColePBryan left a comment

aasseman commented May 2, 2023 •

edited

Loading

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

Aggregator service #71

Aggregator service #71

Conversation

aasseman commented Apr 28, 2023

ColePBryan left a comment

Choose a reason for hiding this comment

aasseman commented May 2, 2023 • edited Loading

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

github-actions bot commented May 2, 2023

aasseman commented May 2, 2023 •

edited

Loading