The War Within - Update #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for WW
- Fixed - Resolved an issue where `TooltipUtil.SurfaceArgs` was called without proper checks, leading to Lua errors - Fixed - Corrected quest tracking when using the `QUEST_ACCEPTED`, `QUEST_REMOVED`, and `QUEST_WATCH_LIST_CHANGED` events - Added - Fallback logic for tooltip processing in `GetQuestProgress` to handle cases where `TooltipUtil.SurfaceArgs` is unavailable - Updated - Enhanced `UpdateQuestIcon` function to better handle quest progress updates and ensure icons display correctly for all quest states - Updated - Refined event handling for `PLAYER_LOGIN` to correctly populate the `ActiveWorldQuests` table based on the player's current map - Improved - Re-anchored quest icons on nameplates during the `ADDON_LOADED` event to ensure settings are correctly applied - Updated - ToC for _retail_ - The War Within Expansion Release Patch (10.2.0.56110) [ToC.110002]
|
Awesome work, thanks for this PR |
|
Fyi, |
- Fixed - Resolved an issue where `TooltipUtil.SurfaceArgs` was called without proper checks, leading to Lua errors - Fixed - Corrected quest tracking when using the `QUEST_ACCEPTED`, `QUEST_REMOVED`, and `QUEST_WATCH_LIST_CHANGED` events - Added - Fallback logic for tooltip processing in `GetQuestProgress` to handle cases where `TooltipUtil.SurfaceArgs` is unavailable - Updated - Enhanced `UpdateQuestIcon` function to better handle quest progress updates and ensure icons display correctly for all quest states - Updated - Refined event handling for `PLAYER_LOGIN` to correctly populate the `ActiveWorldQuests` table based on the player's current map - Improved - Re-anchored quest icons on nameplates during the `ADDON_LOADED` event to ensure settings are correctly applied - Updated - ToC for _retail_ - The War Within Expansion Release Patch (10.2.0.56110) [ToC.110002]
- Fixed - Resolved an issue where `TooltipUtil.SurfaceArgs` was called without proper checks, leading to Lua errors - Fixed - Corrected quest tracking when using the `QUEST_ACCEPTED`, `QUEST_REMOVED`, and `QUEST_WATCH_LIST_CHANGED` events - Added - Fallback logic for tooltip processing in `GetQuestProgress` to handle cases where `TooltipUtil.SurfaceArgs` is unavailable - Updated - Enhanced `UpdateQuestIcon` function to better handle quest progress updates and ensure icons display correctly for all quest states - Updated - Refined event handling for `PLAYER_LOGIN` to correctly populate the `ActiveWorldQuests` table based on the player's current map - Improved - Re-anchored quest icons on nameplates during the `ADDON_LOADED` event to ensure settings are correctly applied - Updated - ToC for _retail_ - The War Within Expansion Release Patch (10.2.0.56110) [ToC.110002]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Version 2.0.0-------------------------------------------------------------------
TooltipUtil.SurfaceArgswas called without proper checks, leading to Lua errorsQUEST_ACCEPTED,QUEST_REMOVED, andQUEST_WATCH_LIST_CHANGEDeventsGetQuestProgressto handle cases whereTooltipUtil.SurfaceArgsis unavailableUpdateQuestIconfunction to better handle quest progress updates and ensure icons display correctly for all quest statesPLAYER_LOGINto correctly populate theActiveWorldQueststable based on the player's current mapADDON_LOADEDevent to ensure settings are correctly applied