Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1300 1302 handling #65

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Update 1300 1302 handling #65

merged 1 commit into from
Jan 8, 2025

Conversation

semuadmin
Copy link
Contributor

@semuadmin semuadmin commented Jan 8, 2025

pyrtcm Pull Request Template

Description

  1. Refine handling of string attributes (e.g. DF140, DF563, DF566).
  2. Add optional 'parsed' argument to RTCMReader - 1 = return raw and parsed data, 0 = return only raw data (parsed will be None)
  3. Temporarily suppress 1302 test cases NB: currently, sample 1302 messages from euref-ip.net:2101/EUREF01 appear to be truncated (to 59 bytes), causing a Error processing attribute 'group-DF568' in message type 1302 negative shift count exception; this mountpoint's data stream also causes the BNC 2.13.1 NTRIP client to bomb every time, so possibly an issue with the source implementation or documentation???

Fixes object has no attribute 'DF569' error when parsing 1302 messages - BUT see known issue above

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Tests updated in test_stream.py

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my RTCM documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added bug Something isn't working enhancement New feature or request labels Jan 8, 2025
@semuadmin semuadmin added this to the RC 1.1.4 milestone Jan 8, 2025
@semuadmin semuadmin self-assigned this Jan 8, 2025
@semuadmin semuadmin marked this pull request as draft January 8, 2025 17:09
@semuadmin semuadmin requested a review from a team January 8, 2025 17:09
@semuadmin semuadmin marked this pull request as ready for review January 8, 2025 17:23
@semuadmin semuadmin merged commit 7d859f5 into main Jan 8, 2025
5 checks passed
@semuadmin semuadmin deleted the RELEASE-CANDIDATE-1.1.4 branch January 8, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant