-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix analyses from partitions are considered in manage analyses view #2598
base: 2.x
Are you sure you want to change the base?
Conversation
I think there was a concern regarding this PR, but I don't see it in the comments here. Can you remember? I'll check it otherwise later. |
Ah, probably that you cannot enter anymore results from the root sample, but need to go directly to the partition instead 🤔 |
It is possible to enter results from the root sample. See below: I've been playing around and I've realized that if you have a given test (e.g. |
The default behaviour before this PR when adding a service to a partition via "Manage Analyses" is that the system first checks for a counterpart analysis in the root sample. If found, it moves the analysis to the partition instead of creating a new one. This is ok for when a partition is being created, but once created, user should be able to add analyses in the partition regardless of the root. Likewise, the addition of analyses in root should not entail changes in the partition. Since this "dependency" logic is encoded in the datamanager, is not possible to make "Manage analyses" work properly for root sample and partitions without breaking the partition creation functionality. Therefore, I think that the logic for moving analyses from root to partitions should not reside in the datamanager, but explicitly handled on partition creation. Will revisit and modify this PR and apply the changes in accordance to ensure system works as expected in both scenarios. Related: #1505 |
Description of the issue/feature this PR addresses
This Pull Request comes as an answer to #2593 (comment) by ensuring that from "Manage analyses" view is only possible to add/remove analyses that belong to current sample, leaving analyses from partitions out of the equation. Likewise, analyses from parent sample are not being considered when managing analyses from a partition.
Current behavior before PR
Manage analyses view takes analyses from partitions into account
Desired behavior after PR is merged
Manage analyses view does not take analyses from partitions into account
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.