Fixes #133

senseiwells · May 30, 2024 · 87bf93c · 87bf93c
1 parent 7f4c293
commit 87bf93c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/build.gradle b/build.gradle
@@ -87,11 +87,7 @@ jar {
 publishMods {
 	file = remapJar.archiveFile
 	changelog = """
-	- Updated to 1.20.5
-	
-	There are still a number of issues with this update, namely clientscript issues (to do with item nbt).
-	As well as networking issues. GameRule syncing between EssentialAddons and EssentialClient will work
-	however ChunkDebug is not fully supported yet and will be ported later.
+	- Updated to 1.20.6
 	"""
 	type = STABLE
 	modLoaders.add("fabric")

diff --git a/...main/java/me/senseiwells/essentialclient/clientscript/definitions/MinecraftClientDef.java b/...main/java/me/senseiwells/essentialclient/clientscript/definitions/MinecraftClientDef.java
@@ -687,7 +687,9 @@ private Void playSound(Arguments arguments) {
 		Double volume = arguments.nextPrimitive(NumberDef.class);
 		Double pitch = arguments.nextPrimitive(NumberDef.class);
 		SoundEvent soundEvent = Registries.SOUND_EVENT.get(ClientScriptUtils.stringToIdentifier(soundId));
-		player.playSoundToPlayer(soundEvent, SoundCategory.MASTER, volume.floatValue(), pitch.floatValue());
+		ClientScriptUtils.ensureMainThread("playSound", arguments.getInterpreter(), () -> {
+			player.playSoundToPlayer(soundEvent, SoundCategory.MASTER, volume.floatValue(), pitch.floatValue());
+		});
 		return null;
 	}