Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop shovel tasks from choking in docstring newlines #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philadams-zz
Copy link
Contributor

No description provided.

@dlecocq
Copy link
Contributor

dlecocq commented Feb 7, 2014

Looks good to me, though you'll have to fix the failing test, and it would be nice to add a test that explicitly tests this case.

@philadams-zz
Copy link
Contributor Author

Can do... the test that fails (when I run make test) is an ImportError for test_run.py: from path import path. Is that os.path?

I'm testing with the makefile, having run a `python setup.py develop' - is this not the right way to go?

Oh, and once I've made the changes / added a test, do I close this pull request and open a new one? What's the recommended way of updating my pull request?

@dlecocq
Copy link
Contributor

dlecocq commented Feb 7, 2014

Ah, that's path.py. I'm working on getting a saner setup.py -- will keep you posted.

@philadams-zz
Copy link
Contributor Author

Sounds good - I'll work on the test and then wait to hear about that path import.

@dlecocq
Copy link
Contributor

dlecocq commented Feb 10, 2014

I just pushed a change to master that details how to get these tests running. Now you can:

python setup.py nosetests`

That installs all the requisite packages and then runs the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants