CLI modification #238
Merged
CLI modification #238
+173
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #238 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 4 4
Lines 722 722
Branches 108 108
=======================================
Hits 718 718
Misses 2 2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
test/error_test.py
Outdated
Comment on lines
63
to
64
| ... | ||
| samila.errors.samilaPlotError: Given color/bgcolor type is not supported. | ||
| samila.errors.samilaPlotError: Plotting process can't be Done because data1 is empty. Use generate method first. |
There was a problem hiding this comment.
Done --> done
Alos how are these changed without any changes in params.py? Either now or then tests should be failed, right?
There was a problem hiding this comment.
Due to the IGNORE_EXCEPTION_DETAIL flag in the pytest.ini file, all exception messages were being ignored.
There was a problem hiding this comment.
Done-->done
fix in c23ef8d
sadrasabouri
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?
@sadrasabouri
We will include tests for the CLI functions in version 1.5