Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] std::is_trivial is deprecated (sdsl) #3340

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Feb 18, 2025

It's not included via -isystem anymore, so we see the deprecation warning.

Note that we could add a #pragma GCC system_header to mark it as system header.
This is also accepted by Clang.

@eseiler eseiler requested a review from SGSSGene February 18, 2025 06:19
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 18, 2025
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3340

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (f9e5403) to head (50cd9ce).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3340   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         270      270           
  Lines       11913    11913           
  Branches      103      103           
=======================================
  Hits        11689    11689           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseiler eseiler enabled auto-merge February 18, 2025 06:33
@eseiler eseiler requested a review from SGSSGene February 18, 2025 10:31
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Feb 18, 2025
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@eseiler eseiler merged commit 1ed89ee into seqan:main Feb 18, 2025
40 checks passed
@eseiler eseiler deleted the fix/sdsl branch February 18, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants