Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add architecture and image count #22

Merged
merged 9 commits into from
Jan 14, 2025
Merged

Add architecture and image count #22

merged 9 commits into from
Jan 14, 2025

Conversation

munishchouhan
Copy link
Member

@munishchouhan munishchouhan commented Jan 9, 2025 •
edited
Loading

This PR will add image architecture column

@munishchouhan munishchouhan self-assigned this Jan 9, 2025
@munishchouhan munishchouhan marked this pull request as draft January 9, 2025 09:46
@munishchouhan
Copy link
Member Author

Screenshot 2025-01-07 at 16 34 40

@pditommaso
Copy link

What's "image count" in this context?

@munishchouhan
Copy link
Member Author

What's "image count" in this context?

Sum of tags for all the repositories

@fntlnz fntlnz self-requested a review January 10, 2025 11:56
@fntlnz
Copy link
Collaborator

fntlnz commented Jan 10, 2025

lgtm so far, well done @munishchouhan - will take a look once you have the tag count as well. I don't think that the registry API exposes that information directly but you should be able to count the tags we have in the local async.Async registry under repositoryTags

@munishchouhan
Copy link
Member Author

lgtm so far, well done @munishchouhan - will take a look once you have the tag count as well. I don't think that the registry API exposes that information directly but you should be able to count the tags we have in the local async.Async registry under repositoryTags

Thanks a lot for the review
yes, I am working on it thanks for the pointer

@munishchouhan
Copy link
Member Author

Tested locally
Screenshot 2025-01-13 at 16 15 26

@munishchouhan munishchouhan marked this pull request as ready for review January 13, 2025 15:20
@munishchouhan munishchouhan requested a review from ewels January 14, 2025 09:19
@fntlnz fntlnz force-pushed the WV-64-Add-counter-arch-and-filter-in-staticreg-UI-to-get-container-image-details branch from f9db766 to 745c040 Compare January 14, 2025 10:08
@munishchouhan
Merge remote-tracking branch 'origin/WV-64-Add-counter-arch-and-filte…
9f4850e 
…r-in-staticreg-UI-to-get-container-image-details' into WV-64-Add-counter-arch-and-filter-in-staticreg-UI-to-get-container-image-details

# Conflicts:
#	pkg/filler/filler.go
#	pkg/registry/async/async_registry.go
#	pkg/registry/client.go
#	pkg/registry/registry/registry.go
#	pkg/templates/tmpl/index.html
pditommaso
pditommaso requested changes Jan 14, 2025
View reviewed changes
Copy link

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The architecture info is useful, while I cannot say the same for image count. I think it should not be added

@munishchouhan
Copy link
Member Author

The architecture info is useful, while I cannot say the same for image count. I think it should not be added

Noted, I will remove it

@munishchouhan
Copy link
Member Author

@pditommaso image count has been removed

@pditommaso
Copy link

Can an updated screenshot be included?

@munishchouhan
Copy link
Member Author

Screenshots:
Screenshot 2025-01-14 at 11 34 37
Screenshot 2025-01-14 at 11 34 46

pditommaso
pditommaso approved these changes Jan 14, 2025
View reviewed changes
Copy link

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@munishchouhan munishchouhan merged commit e6ba233 into master Jan 14, 2025
1 check passed
@ewels ewels deleted the WV-64-Add-counter-arch-and-filter-in-staticreg-UI-to-get-container-image-details branch January 14, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fntlnz fntlnz fntlnz approved these changes

@pditommaso pditommaso pditommaso approved these changes

@ewels ewels Awaiting requested review from ewels

Assignees

@munishchouhan munishchouhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@munishchouhan @pditommaso @fntlnz