Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TS Config to support new decorators model definition #272

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Update TS Config to support new decorators model definition #272

merged 4 commits into from
Mar 25, 2024

Conversation

johneatmon
Copy link
Contributor

Redo of #267:

Based on this issue and this issue.

Update tsconfig.json:

  • Add support for experimentalDecorators
  • Bump module and moduleResolution to import @sequelize/core/decorators-legacy declarations properly

Update sscce-sequelize-7.ts:

  • Add new Bar model to demonstrate new model definition example with decorators

@johneatmon johneatmon mentioned this pull request Feb 13, 2024
Closed
@WikiRik WikiRik requested a review from ephys February 13, 2024 17:15
ephys
ephys requested changes Feb 18, 2024
View reviewed changes
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change request, but otherwise good! :)

src/sscce-sequelize-7.ts Outdated Show resolved Hide resolved
@johneatmon
Copy link
Contributor Author

Voilà

ephys
ephys approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ephys ephys merged commit 97871ef into sequelize:main Mar 25, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johneatmon @ephys