Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Wii port to SDL2 #55

Closed
wants to merge 1 commit into from
Closed

Migrate Wii port to SDL2 #55

wants to merge 1 commit into from

Conversation

mardy
Copy link

@mardy mardy commented Mar 10, 2024

I didn't actually try the CI, just a local build. It seems to work fine :-)

@sergiou87
Copy link
Owner

CI doesn't work because it's based on a Docker image that doesn't contain SDL2… that would require to update https://github.com/sergiou87/open-supaplex/blob/master/ci/Dockerfile-wii with the new dependencies, then I like to push a new image to my Docker account and update this line with the new image.

@sergiou87
Copy link
Owner

Btw does upgrading to SDL2 bring any improvements to the Wii version?

@mardy
Copy link
Author

mardy commented Mar 11, 2024

CI doesn't work because it's based on a Docker image that doesn't contain SDL2… that would require to update https://github.com/sergiou87/open-supaplex/blob/master/ci/Dockerfile-wii with the new dependencies

That is done, but I didn't actually build the image :-)

Btw does upgrading to SDL2 bring any improvements to the Wii version?

Honestly, I'm not aware of any. If you know of some bugs that were there in the SDL1 version, I can check and see if they are gone.

@sergiou87
Copy link
Owner

Honestly, I'm not aware of any. If you know of some bugs that were there in the SDL1 version, I can check and see if they are gone.

My question then is… why upgrading it then? I tested the existing version with SDL1 on Wii back in the day and it worked well, so I'd be afraid of breaking anything with changes if they don't add anything 😳

@mardy
Copy link
Author

mardy commented Mar 11, 2024

My question then is… why upgrading it then?

I submitted it just in case one day you'll have all platforms on SDL2, so that you can drop SDL1. Feel free to do what you want with this :-)

@sergiou87
Copy link
Owner

Since I don't have bandwidth to work on this I will close it. If needed in the future it should be easy to reopen. Sorry and thank you for your contribution 💖

@sergiou87 sergiou87 closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants