Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with panel visibility and save states #60

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ftortoriello
Copy link
Contributor

When a state is saved when the panel was hidden, and that state is loaded with the panel visible, the panel remains visible, but the playfield is behind the panel. If you press Enter the panel remains visible and the playfield is adjusted.
Likewise, if the panel is hidden and a state is loaded with the panel visible, you need to press Enter to show it.

Fix that issue by setting the gCurrentPanelHeight variable when loading a save state.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
When a state is saved when the panel was hidden, and that state is loaded with
the panel visible, the panel remains visible, but the playfield is
behind the panel. If you press Enter the panel remains visible and the
playfield is adjusted.
Likewise, if the panel is hidden and a state is loaded with the panel
visible, you need to press Enter to show it.

Fix that issue by setting the gCurrentPanelHeight variable when loading
a save state.
Copy link
Owner

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💖

@sergiou87 sergiou87 merged commit 4d5cf8a into sergiou87:master Sep 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants