Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mark and Space variants to Parity enum #189

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add Mark and Space variants to Parity enum #189

wants to merge 5 commits into from

Conversation

YgorSouza
Copy link

Closes #167

@YgorSouza
Copy link
Author

Note that since the Parity enum is not marked #[non_exhaustive], this is a breaking change and requires a major version bump.

Also, I have not tested this yet, and I'm not sure I'll have access to a serial device with mark/space parity to test soon. If someone else could test, that would be appreciated.

sirhcel
sirhcel requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@sirhcel sirhcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would provide Parity::Mark and Parity::Space only for backends actually supporting it.

src/posix/termios.rs Outdated Show resolved Hide resolved
src/posix/termios.rs Outdated Show resolved Hide resolved
@sirhcel sirhcel added this to the 5.0.0 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirhcel sirhcel sirhcel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Can Add Mark and Space to Parity?
2 participants
@YgorSouza @sirhcel