-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows unicode (_W
) api for all Win32 functions
#89
Commits on Jul 31, 2024
-
query windows registry for all COM ports
individual unsafe blocks driveby resolve clippy lint add `Modem` as a device class to query for COM ports some refactoring of `get_ports_guids` to handle multiple class names clarifying comment filter to COM ports rather than removing LPT (unknown what else modems could show up as) raw ports only need to be iterated if additional ports have been found resolve typo in comment str -> w_string function critique the moethod later... `get_ports_guids` using `_W` win32 API `PortDevices::new()` using `_W` win32 API `PortDevices::instance_id()` using `_W` win32 API `PortDevices::name()` using `as_utf16` add utf16->utf8 function handles the conversion and null trimming use `from_utf16_lossy_trimmed` `PortDevice::property()` handling a larger than expected property by retrying `get_registry_com_ports` using utf16 API also removed all the unused optional parameters from `RegQueryInfoKey` minor cleanup
Configuration menu - View commit details
-
Copy full SHA for 69c0d24 - Browse repository at this point
Copy the full SHA 69c0d24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64e5566 - Browse repository at this point
Copy the full SHA 64e5566View commit details -
Configuration menu - View commit details
-
Copy full SHA for d858e9e - Browse repository at this point
Copy the full SHA d858e9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03225bc - Browse repository at this point
Copy the full SHA 03225bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87352d0 - Browse repository at this point
Copy the full SHA 87352d0View commit details -
Harmonize checks after querying registry values
Let's use the same type names, variable names, and the same checks for easily comparing them.
Configuration menu - View commit details
-
Copy full SHA for 435959c - Browse repository at this point
Copy the full SHA 435959cView commit details -
Don't ignore insufficient buffer size for no obvious reason
There is neither an explanation in the code nor does the history of this check reveal any insight in why it should be present. If the buffer is too small, what are we getting then, truncated data? I don't see the point in processing this data.
Configuration menu - View commit details
-
Copy full SHA for e20f70a - Browse repository at this point
Copy the full SHA e20f70aView commit details -
Check type of data from SetupDiGetDevicePropertyW too
Let's check it the same way as for other registry data.
Configuration menu - View commit details
-
Copy full SHA for 28752f7 - Browse repository at this point
Copy the full SHA 28752f7View commit details -
Harmonize the buffer sizes used here. If we are already in the mood for spending 100 characters, MAX_PATH won't hurt either.
Configuration menu - View commit details
-
Copy full SHA for bb2a95a - Browse repository at this point
Copy the full SHA bb2a95aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1bf351 - Browse repository at this point
Copy the full SHA f1bf351View commit details
Commits on Aug 1, 2024
-
Clean up nomenclature for character size
Co-authored-by: Christopher Smyth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c7a3d24 - Browse repository at this point
Copy the full SHA c7a3d24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b54550 - Browse repository at this point
Copy the full SHA 0b54550View commit details