Stop using obsolete inheritance-based PeriodicBatchingSink API #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PeriodicBatchingSinklibrary had deprecated passing the subclass ofPeriodicBatchingSinktologgerSinkConfiguration.Sink(), and then removed support for the obsolete approach. Since the Graylog batching sink was not updated, attempting to initialize it resulted in #97.While
PeriodicBatchingSinkreintroduced the removed APIs to maintain backwards compatibility in version 3.1.0, the Graylog batching sink references version 2.3.1. An easier solution would have been to simply update thePeriodicBatchingSinkdependency to 3.1.0 but then we would still be depending on obsolete code which has already been removed once.This updates the batching sink to use the correct approach instead.