Added thread for message processing #14
Conversation
|
|
|
Thanks @Skaptor ! Looks promising. Will take a deeper look in the next few days 👍 |
src/Serilog.Sinks.RichTextBox.Wpf/Sinks/RichTextBox/RichTextBoxSink.cs
Outdated
Show resolved
Hide resolved
src/Serilog.Sinks.RichTextBox.Wpf/Sinks/RichTextBox/RichTextBoxSink.cs
Outdated
Show resolved
Hide resolved
src/Serilog.Sinks.RichTextBox.Wpf/Sinks/RichTextBox/RichTextBoxSink.cs
Outdated
Show resolved
Hide resolved
src/Serilog.Sinks.RichTextBox.Wpf/Sinks/RichTextBox/RichTextBoxSink.cs
Outdated
Show resolved
Hide resolved
|
Sure I'll make the adjustments. I maybe broke something because I used the vscode web version |
|
Hi! What's the status of this? Really hoping for an update. |
|
Changes are ready, we are waiting for @augustoproiete to approve the latest PR. |
|
Awesome! @TonyValenti are you able to take this one for a spin? |
augustoproiete
force-pushed
the
master
branch
from
02e7c49 to
78ec6f9
Compare
|
@augustoproiete what are the latest changes you'd like me to make? |
|
@augustoproiete - can you publish an updated nuget package I can use? |
augustoproiete
force-pushed
the
master
branch
from
78ec6f9 to
cdcbf4f
Compare
|
@Skaptor None at this point. Will take a deeper look at the code in the next few days @TonyValenti NuGet package is here (package artifact), unzip into a local feed/folder |
|
@augustoproiete OK. agreed. |
|
Hello, is there any new update on this? |
|
When will this be committed? @augustoproiete - If you're not able to maintain this project, can you make me an admin? I have a vested interest in this being advanced. |
|
@TonyValenti did you test the artifact nupkg? how did it work? |
|
@TonyValenti See messages above - This needs manual testing, didn't hear back from you since Oct 18th #14 (comment) |
augustoproiete
force-pushed
the
master
branch
2 times, most recently
from
278218a to
b6c7fff
Compare
|
Thanks! I'll grab the source and do a deep test later today/tomorrow. |
|
@TonyValenti How did the test go? I imagine merging this will have an impact on #32 so might be good to get this one merged first and release a new preview |
|
I wasn't able to figure out how to test it without it being merged. Please merge then I'll review and resolve any issues. My changes on my PR are minimal to existing code and I'd be surprised if there were any issues that took longer than a second to resolve. |
|
@TonyValenti Download the NuGet package is here (package artifact), unzip into a local feed/folder |
|
This works great. |
augustoproiete
force-pushed
the
master
branch
from
b6c7fff to
d595cbb
Compare
|
@Skaptor your changes have been merged, thanks for your contribution 👍 |
|
@augustoproiete Happy to help. Thank you for this sink! |
I took the embedded state machine approach and made a state machine based thread that waits roughly 25ms or a message counter to reach a certain batch size for reducing the amount of dispatcher calls. I ran the tests and nothing broke 👍. It is noticeable faster than calling the dispatcher method for each message that is being logged. All suggestions are accepted.