Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use tailwind, turn into module, simplify styles #242

Closed
wants to merge 2 commits into from

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Jan 29, 2025

(postponed until I figure out the test error)

@elbotho elbotho marked this pull request as draft January 29, 2025 15:53
@hejtful
Copy link
Collaborator

hejtful commented Jan 31, 2025

What was the need for using fileURLToPath(import.meta.url) here? Did some tool not pick up on __dirname?

We switched to CommonJS with this PR, and CommonJS doesn't support import.meta.url.

@elbotho
Copy link
Member Author

elbotho commented Jan 31, 2025

@hejtful in the PR you linked we still have the "type": "module", right?
(the backend part should not matter here I thought)

I think the new tailwind version (v4) did not play well without esm.
Do you know when and why we returned to commonjs?

(We could also go with tailwind v3 or no tailwind at all until we potentially move to a framework for this)

Base automatically changed from show-header-when-not-in-iframe to development January 31, 2025 11:06
@elbotho elbotho mentioned this pull request Jan 31, 2025
@elbotho
Copy link
Member Author

elbotho commented Jan 31, 2025

replaced by #244

@elbotho elbotho closed this Jan 31, 2025
@hejtful
Copy link
Collaborator

hejtful commented Jan 31, 2025

@elbotho I don't remember exactly why, it had to do with deploying to Uberspace. Sorry, should have documented that better.

@kulla kulla deleted the refactor/tailwind branch February 11, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants