[#245] Return non-zero exit code in case of confirmation timeout #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon closer look it appears that this change is limited to the remote side, the deploying host should receive the timeout reliably 🤔 |
PhilTaken
reviewed
Dec 11, 2023
src/bin/activate.rs
Outdated
| @@ -464,7 +456,7 @@ pub async fn activate( | |||
| if magic_rollback && !boot { | |||
| info!("Magic rollback is enabled, setting up confirmation hook..."); | |||
|
|
|||
| match activation_confirmation(profile_path.clone(), temp_path, confirm_timeout, closure) | |||
| match activation_confirmation(temp_path, confirm_timeout, closure) | |||
There was a problem hiding this comment.
I think this block makes more sense as an if let
AFAICS, the corresponding |
|
right, and then the exit code is propagated through the connection. perfect then. LGTM |
PhilTaken
approved these changes
Dec 11, 2023
Problem: When profile activation confirmation fails due to confirmation timeout and performs a rollback, zero exit code is returned. Such a behavior is confusing since rollback usually means something went wrong during deployment and it shouldn't return successful exit code. Solution: Explicitly return confirmation waiting error instead of printing it and silently signalizing success.
rvem
force-pushed
the
rvem/#245-return-non-zero-exit-code-for-confirmation-timeout
branch
from
6e9f729 to
b076e35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When profile activation confirmation fails due to
confirmation timeout and performs a rollback, zero exit code is
returned. Such a behavior is confusing since rollback usually means
something went wrong during deployment and it shouldn't return
successful exit code.
Solution: Explicitly return confirmation waiting error instead of
printing it and silently signaling success.
Resolves #245