Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout in seconds, set timeout at GoogleSearch instantiation, add ssl_verify parameter #67

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ashishkulkarnii
Copy link

This PR has three commits:

  1. Timeout in the requests library is in seconds (not milliseconds). Changed default timeout to 60 seconds.
  2. Fixing issue 40 by allowing timeout to be set at GoogleSearch object instantiation.
  3. Control over SSL verification parameter of the requests library at search object instantiation is a pretty useful feature, as on some networks, using requests.get(..., verify=True) throws SSLHandshakeError. A problem that I, and others, face. Fixed it by adding ssl_verify parameter during object instantiation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant