-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make crates/triggers API suitable for usysconf #240
base: fnmatch-simplify
Are you sure you want to change the base?
Conversation
d0ea498
to
e0d17e4
Compare
I think we should review (and hopefully accept) this PR before moving to usysconf. This PR in fact is the core API for both moss and usysconf. If there's something fishy here, there's something fishy everywhere. |
e0d17e4
to
35048d2
Compare
d9402b8
to
03d9ce9
Compare
35048d2
to
f510a50
Compare
|
1 similar comment
|
This is my attempt to decouple the current crates/triggers code, which was written specifically with moss in mind, to make it as generic as possible. Particularly, we want to re-write Solus' usysconf tool in Rust, leveraging the Serpent OS tech stack. usysconf works differently from "moss-triggers", yet we want to share as much code as possible. See this message for reference: serpent-os/usysconf-rs#1 (comment)
NOTE: This PR sits on top of #191 and in fact pours its commit in the fnmatch-simplify branch. This is for simplicity, so that every PR only sees its relevant subset of commits. We'll eventually merge fn-simplify into main.