Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make crates/triggers API suitable for usysconf #240

Open
wants to merge 4 commits into
base: fnmatch-simplify
Choose a base branch
from

Conversation

livingsilver94
Copy link
Contributor

@livingsilver94 livingsilver94 commented May 10, 2024

This is my attempt to decouple the current crates/triggers code, which was written specifically with moss in mind, to make it as generic as possible. Particularly, we want to re-write Solus' usysconf tool in Rust, leveraging the Serpent OS tech stack. usysconf works differently from "moss-triggers", yet we want to share as much code as possible. See this message for reference: serpent-os/usysconf-rs#1 (comment)

NOTE: This PR sits on top of #191 and in fact pours its commit in the fnmatch-simplify branch. This is for simplicity, so that every PR only sees its relevant subset of commits. We'll eventually merge fn-simplify into main.

@ermo ermo added status: help wanted Need an extra set of eyes on this. type: enhancement New feature or request labels May 14, 2024
@livingsilver94
Copy link
Contributor Author

I think we should review (and hopefully accept) this PR before moving to usysconf. This PR in fact is the core API for both moss and usysconf. If there's something fishy here, there's something fishy everywhere.

@livingsilver94 livingsilver94 changed the base branch from main to fnmatch-simplify July 26, 2024 10:55
@livingsilver94 livingsilver94 marked this pull request as draft July 26, 2024 10:59
@livingsilver94 livingsilver94 marked this pull request as ready for review July 26, 2024 11:18
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted Need an extra set of eyes on this. type: enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants