Fixes Issue #2 and #3 #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2016 14:37
… incoming year is correct (and is NOT being messed with), the months should be treated accordingly
|
Excellent 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #2
Since the articles are being parsed based on their created timestamp, and the year is not being monkeyed-about with, there's no reason for the code to monkey-about with the incoming month data either. Removed the random
+and- 1's~~, as well as the unknown-purpose %12. Restart rails server and bob's-your-uncle.~~Edit:
Upon further review, this also resolves issue #3 :
Removing the
%12fixes the disorder which was causing the months to appear out-of-order