Add Fira Code, Input Mono, Support ligatures #16
Conversation
|
Mind splitting Input Mono out into a separate PR so that we can sort out the license issue? Otherwise we can hold on this until we have clarification. May need to contact the team there to confirm that this use falls within what is acceptable based upon the license. Didn't realize that they were using a restrictive license when I suggested the face. |
|
@chrissimpkins This PR adds Input Mono only for the case that you have it locally. No files are redistributed as web font. |
| @@ -227,3 +227,8 @@ body.vertical.fullscreen pre.playground { | |||
| font-size: 1.5em; | |||
| } | |||
| } | |||
|
|
|||
| .ace_content { | |||
There was a problem hiding this comment.
This is applied to the WYSIWYG code editor.
| @@ -45,7 +45,7 @@ | |||
|
|
|||
| <!-- CSS Customization --> | |||
| <link rel="stylesheet" href="assets/css/custom.css"> | |||
| <link rel="stylesheet" href="assets/css/playground.css"> | |||
| <link rel="stylesheet" href="assets/css/playground.css?ver=20170919"> | |||
There was a problem hiding this comment.
This forces browsers to ignore their cache.
| @@ -132,8 +132,10 @@ | |||
| <option data-href="https://damieng.com/blog/2008/05/26/envy-code-r-preview-7-coding-font-released">Envy Code R</option> | |||
| <option data-href="https://github.com/belluzj/fantasque-sans">Fantasque Sans Mono</option> | |||
| <option data-href="http://mozilla.github.io/Fira/" data-webfont>Fira Mono</option> | |||
| <option data-href="http://mozilla.github.io/Fira/" data-webfont="custom">Fira Code</option> | |||
There was a problem hiding this comment.
Offer Fira Code from our fonts folder (see files added with this PR).
| <option data-href="https://github.com/i-tu/Hasklig/">Hasklig</option> | ||
| <option data-href="http://www.levien.com/type/myfonts/inconsolata.html" data-webfont>Inconsolata</option> | ||
| <option data-href="http://input.fontbureau.com/">Input Mono</option> |
There was a problem hiding this comment.
Add Input Mono if installed locally – no webfont for now.
|
@jublo thanks JM. These new Fira Code web fonts their releases or did you generate new web fonts from their releases? |
| @@ -45,7 +45,7 @@ | |||
|
|
|||
| <!-- CSS Customization --> | |||
| <link rel="stylesheet" href="assets/css/custom.css"> | |||
| <link rel="stylesheet" href="assets/css/playground.css"> | |||
| <link rel="stylesheet" href="assets/css/playground.css?ver=20170919"> | |||
| /* Source: https://github.com/tonsky/FiraCode */ | ||
|
|
||
| @font-face{ | ||
| font-family: 'Fira Code'; |
There was a problem hiding this comment.
Do you think that we still need to support all of these web font file types? Based upon source-foundry/Hack#286 (comment) and source-foundry/Hack#286 (comment) it seems that we can simplify this to woff and woff2 since there is support in nearly all modern browsers at this stage. Thoughts?
Not necessary for this PR but a thought for down the road.
There was a problem hiding this comment.
Let’s remove TTF, EOT and SVG (if any) at a later stage and open an issue for it.
|
Looks great @jublo! cc: @burodepeper |
See #15.