Add para assignment dialog #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #236.
codetheweb
commented
Nov 6, 2023
| <Box sx={{ px: 2, pb: 2 }}> | ||
| <Alert severity="info" sx={{ mb: 2 }}> | ||
| <AlertTitle>Benchmark</AlertTitle> | ||
| By October, when given a list of 20 unfamiliar words that contain |
There was a problem hiding this comment.
where can we pull this from?
There was a problem hiding this comment.
Looks like the closest API we've made is iep.getSubgoalAndTrialData, for data collection, which we are using in /src/pages/benchmarks/[benchmark_id]/index.tsx, but we do not yet have an API for an individual Subgoal without the Trial data.
There was a problem hiding this comment.
We also have iep.tempAddTaskToSelf for assignment,being used in the Subgoal.tsx
| </List> | ||
| </Box> | ||
| <Box sx={{ display: "flex", justifyContent: "end" }}> | ||
| <Button variant="contained" onClick={handleClose}> |
| // task.mutate({ | ||
| // subgoal_id: subgoal.subgoal_id, | ||
| // assignee_id: data.get("assignee_id") as string, | ||
| // due_date: new Date(data.get("due_date")) as Date |
There was a problem hiding this comment.
Let's be sure to test this when we implement it, to ensure it comes through as the correct date.
tessathornberry
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236.
Demo:
Screen.Recording.2023-11-05.at.9.50.21.PM.mov