Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor CSS Fixes (sticky nav and layout) #299

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Minor CSS Fixes (sticky nav and layout) #299

merged 8 commits into from
Apr 9, 2024

Conversation

hannahmcg
Copy link
Contributor

Made navbar sticky and layout background now extends past screen height when content overflows

@hannahmcg hannahmcg linked an issue Mar 5, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@hieungo89 hieungo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using a mobile-first design. Instead of changing it to max-width, you can keep the min-width and change line 13 margin-left: 0;, then at line 43 min-width:992, the margin-left: 200px; kicks in.

src/components/layout/Layout.module.css Outdated Show resolved Hide resolved
@hannahmcg hannahmcg requested a review from hieungo89 April 9, 2024 02:39
@hannahmcg hannahmcg merged commit 63c5bd5 into main Apr 9, 2024
3 checks passed
@hannahmcg hannahmcg deleted the fixNav branch April 9, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Minor CSS Fixes [ENG]
3 participants