Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #468 (extra trial data) - update to prevent rerender #484

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

katconnors
Copy link
Contributor

Behavior described in issue #468 is no longer occuring.
Source of the problem was that useEffect was causing a rerender of the benchmark component in development.

@katconnors katconnors linked an issue Dec 21, 2024 that may be closed by this pull request
@katconnors katconnors requested a review from a team December 21, 2024 05:03
src/pages/benchmarks/[benchmark_id]/index.tsx Outdated Show resolved Hide resolved
@katconnors katconnors merged commit 78c3f95 into main Jan 3, 2025
4 checks passed
@katconnors katconnors deleted the fix-extra-trial branch January 3, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Trial/extra trial data instance creation
2 participants