Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#87 Support avif file format for backgrounds #99

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

shepard8
Copy link
Contributor

@shepard8 shepard8 commented Mar 9, 2023

The parts sfeir-school-theme is responsible for have been fixed.

However, for general slide backgrounds, currently the files need to be named with a file extension allowed by RevealJS.

I opened a ticket on the RevealJS repository (see ticket #87), but this is out of scope of this project, so I guess this branch can be merged already.

@shepard8 shepard8 requested a review from jefBinomed March 9, 2023 13:29
@shepard8 shepard8 self-assigned this Mar 9, 2023
@shepard8 shepard8 added this to the 3.1.0 milestone Mar 9, 2023
@shepard8 shepard8 linked an issue Mar 9, 2023 that may be closed by this pull request
Copy link
Collaborator

@jefBinomed jefBinomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait que tu mettes une image avif pour le prouver :)

@shepard8
Copy link
Contributor Author

shepard8 commented Mar 9, 2023

Le background que j'ai ajouté est un fichier AVIF mais avec l'extension JPG, j'explique ça dans l'issue 87 😃

image

@shepard8
Copy link
Contributor Author

Finally, I added the compiled versions to the patch so that files with the avif extension are usable directly.

I renamed the file as it made no sense anymore to use a fake extension.

@shepard8 shepard8 marked this pull request as ready for review March 10, 2023 07:34
@shepard8
Copy link
Contributor Author

@jefBinomed Je pense qu'il y a encore un souci avec netlify. Patch-package est appliqué (cfr netlify log) mais le résultat n'est pas pris en compte pour construire le sfere-school-theme.mjs.

image

image

Ce qui fait que ni les webp, ni les avif ne sont supportés pour le moment 😞

Si je crée un compte netlify, je peux y regarder moi-même ? Je ne veux pas te faire perdre de temps ^^

Merci,

@jefBinomed
Copy link
Collaborator

J'ai fait les modifs côté netlify pour lancer le prepare-demos après chaque build de cette manière, la démo devrait être ready et correcte maintenant. Dis moi si ça donne ce que tu souhaites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: support avif for background
2 participants