-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#87 Support avif file format for backgrounds #99
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il faudrait que tu mettes une image avif pour le prouver :)
Finally, I added the compiled versions to the patch so that files with the avif extension are usable directly. I renamed the file as it made no sense anymore to use a fake extension. |
@jefBinomed Je pense qu'il y a encore un souci avec netlify. Patch-package est appliqué (cfr netlify log) mais le résultat n'est pas pris en compte pour construire le sfere-school-theme.mjs. Ce qui fait que ni les webp, ni les avif ne sont supportés pour le moment 😞 Si je crée un compte netlify, je peux y regarder moi-même ? Je ne veux pas te faire perdre de temps ^^ Merci, |
J'ai fait les modifs côté netlify pour lancer le prepare-demos après chaque build de cette manière, la démo devrait être ready et correcte maintenant. Dis moi si ça donne ce que tu souhaites |
833b07d
to
439e37c
Compare
The parts sfeir-school-theme is responsible for have been fixed.
However, for general slide backgrounds, currently the files need to be named with a file extension allowed by RevealJS.
I opened a ticket on the RevealJS repository (see ticket #87), but this is out of scope of this project, so I guess this branch can be merged already.