Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/component reuse: Extract Reusable UI Components for Card Detail #14

Merged
merged 9 commits into from
Feb 1, 2025
Merged

Refactor/component reuse: Extract Reusable UI Components for Card Detail #14

merged 9 commits into from
Feb 1, 2025

Conversation

sh1mj1
Copy link
Owner

@sh1mj1 sh1mj1 commented Jan 31, 2025

Work Video

NO

Work Details

  • Extracted Reusable Composables
  • Refactored & Modularized Components
    • CardDetailHeader: Separated the header section from CardDetailScreen.
    • PokemonMoves: Extracted move details into a separate composable.
    • CardAttribute: Displays rarity, type, weakness, HP, retreat cost, and stage.
    • RelatedCardsSection: Now reuses CardItem to ensure UI consistency.
    • RelatedDecksSection: Extracted deck-related content, utilizing PocketDexSectionHeader.
    • PocketDexSectionHeader: Created a common section header component for uniform section titles.
  • File Organization

PR Points

NO

🚀 Next Feature

  • use viewmodel

@sh1mj1 sh1mj1 merged commit b9e7094 into dev Feb 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sh1mj1