Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drupal core issues link #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

joelpittet
Copy link

@joelpittet joelpittet commented Jan 13, 2022

The Problem/Issue/Bug

Link bug to drupal core issue queue

How this PR Solves The Problem

fixes the link

Manual Testing Instructions

click the link

Related Issue Link(s)

Release/Deployment notes

@shaal
Copy link
Owner

shaal commented Jan 13, 2022

Thank you for the fix @joelpittet !

@mradcliffe can you update the VScode extension?

@mradcliffe
Copy link
Contributor

Do you want a new version too, @shaal?

If so, then we would update the package.json version in the extension directory.

Then yarn install, yarn package and yarn publish --packagePath drupalpod-ext-VERSION.vsix given the token.

@mradcliffe
Copy link
Contributor

mradcliffe commented Jan 13, 2022

Or the GitHub action should do it too with npm run ovsx publish -p ${{ secrets.OVSX_TOKEN }}. that requires a DrupalPod release though.

@@ -100,7 +100,7 @@ body {
<strong id="footerNavHeader">Helpful Links:</strong>
<a href="https://github.com/shaal/DrupalPod" class="nav__link">DrupalPod</a>
<a href="https://drupal.org/community/contributor-guide" class="nav__link">Contributor Guide</a>
<a href="https://drupal.org/project/issue/search/drupal" class="nav__link">Core Issue Queue</a>
<a href="https://drupal.org/project/issues/search/drupal" class="nav__link">Core Issue Queue</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Joel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants