Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Reset playRangeEnd value between interstitials #8082

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 14, 2025

This is necessary because you can have two interstitials in a row where the first one uses playRangeEnd but the second one doesn't. Without this fix the second one would have the same playRangeEnd as the first one, but this is wrong.

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release labels Feb 14, 2025
@avelad avelad added this to the v4.14 milestone Feb 14, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 2f3a868 into shaka-project:main Feb 14, 2025
23 of 24 checks passed
@avelad avelad deleted the playRangeEnd-ads branch February 14, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants