Fix rubocop 1.65 compatability #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darhazer
force-pushed
the
rubobop-1-65-compatability
branch
from
487c263 to
7c9bd43
Compare
Darhazer
commented
Jul 10, 2024
| @@ -466,7 +466,7 @@ def self.a; end | |||
| 'Layout/OrderedMethods', | |||
| file.path | |||
| ]) | |||
| expect($stderr.string).to eq('') | |||
There was a problem hiding this comment.
It produces
warning:
support_autocorrect?is deprecated. Usecop.class.support_autocorrect?.
which is harder to fix
Darhazer
force-pushed
the
rubobop-1-65-compatability
branch
from
aa24918 to
f82b938
Compare
Darhazer
force-pushed
the
rubobop-1-65-compatability
branch
from
f82b938 to
0d6d9b5
Compare
|
Thanks for the update and the removing the cache - I wasn't sure exactly how traversing and correcting interacted. |
|
Released in 0.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignored_method?was an alias for alias forallowed_method?for ages. Rubocop 1.65 [broke than method(by essentially making the signature incompatible).This just allows running the cop with no errors. It still produces deprecation warnings around the auto-correct deprecationAlso updated the auto-corrector to use the new API.
Note: I don't see any reason for the caching of the corrector, as nodes are simply passed to the constructor, but traversed during the actual correction. Since RuboCop executed the check again after each correction though (which changed the AST), we should not use a cached version of the siblings.