Merge pull request #412 from jmlich/device-info-service-hw

Add Model characteristics to Device Info Service
sharandac · Jan 26, 2025 · 953243e · 953243e
2 parents ccc4797 + d1ed9bd
commit 953243e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/hardware/ble/deviceinfo.cpp b/src/hardware/ble/deviceinfo.cpp
@@ -37,6 +37,8 @@ void deviceinfo_setup( void ) {
         pManufacturerNameStringCharacteristic->setValue("Lily Go");
         NimBLECharacteristic* pFirmwareRevisionStringCharacteristic = pDeviceInformationService->createCharacteristic( FIRMWARE_REVISION_STRING_CHARACTERISTIC_UUID, NIMBLE_PROPERTY::READ );
         pFirmwareRevisionStringCharacteristic->setValue(__FIRMWARE__);
+        NimBLECharacteristic* pModelStringCharacteristic = pDeviceInformationService->createCharacteristic( MODEL_STRING_CHARACTERISTIC_UUID, NIMBLE_PROPERTY::READ );
+        pModelStringCharacteristic->setValue(HARDWARE_NAME);
         pDeviceInformationService->start();
         pAdvertising->addServiceUUID( pDeviceInformationService->getUUID() );
     #endif

diff --git a/src/hardware/ble/deviceinfo.h b/src/hardware/ble/deviceinfo.h
@@ -28,6 +28,7 @@
     #define DEVICE_INFORMATION_SERVICE_UUID                 (uint16_t)0x180A                           /** @brief Device Information server UUID */
     #define MANUFACTURER_NAME_STRING_CHARACTERISTIC_UUID    (uint16_t)0x2A29                           /** @brief Device Information - manufacturer name string UUID */
     #define FIRMWARE_REVISION_STRING_CHARACTERISTIC_UUID    (uint16_t)0x2A26                           /** @brief Device Information - firmware revision UUID */
+    #define MODEL_STRING_CHARACTERISTIC_UUID                (uint16_t)0x2A24                           /** @brief Device Information - model UUID */
     /**
      * @brief setup gadgetbridge transmit/recieve over ble
      */