Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation guide to VS Code Extension readme #659

Merged

Conversation

Goju-Ryu
Copy link
Contributor

No description provided.

vscode-extension/README.md Outdated Show resolved Hide resolved
@Goju-Ryu
Copy link
Contributor Author

Goju-Ryu commented Jan 1, 2025

There may be some pluming needed for the files to be added when creating a new release but the setup for generating the VSIX file is now in place

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sharkdp
Copy link
Owner

sharkdp commented Jan 5, 2025

@Goju-Ryu
Copy link
Contributor Author

Goju-Ryu commented Jan 5, 2025

Looks like that doesn't work yet: https://github.com/sharkdp/numbat/actions/runs/12614910052/job/35154340319?pr=659#step:7:13.

I will take another stab at it then.

You can also see all the uploaded artifacts here: https://github.com/sharkdp/numbat/actions/runs/12614910052?pr=659

Thank you! I'd been looking for where to check the uploaded artefacts, but couldn't find it. This will be very helpful!

@Goju-Ryu
Copy link
Contributor Author

Goju-Ryu commented Jan 8, 2025

It should now be fixed. Problem was that I set the base path for the bash scrips as being in the vscode-extension folder, but the upload-artefact action didn't use that base path implicitly like the bash scripts did.

Link to artifacts: https://github.com/sharkdp/numbat/actions/runs/12680011071?pr=659
Direct download link: https://github.com/sharkdp/numbat/actions/runs/12680011071/artifacts/2404218978

I have tested the action artifact extension and it worked as expected.

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sharkdp sharkdp merged commit 9f419b8 into sharkdp:master Jan 11, 2025
17 checks passed
@Goju-Ryu Goju-Ryu deleted the vscode-extension-quality-of-life-changes branch January 12, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants