-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation guide to VS Code Extension readme #659
Add installation guide to VS Code Extension readme #659
Conversation
There may be some pluming needed for the files to be added when creating a new release but the setup for generating the VSIX file is now in place |
Looks like that doesn't work yet: https://github.com/sharkdp/numbat/actions/runs/12614910052/job/35154340319?pr=659#step:7:13. You can also see all the uploaded artifacts here: https://github.com/sharkdp/numbat/actions/runs/12614910052?pr=659 |
I will take another stab at it then.
Thank you! I'd been looking for where to check the uploaded artefacts, but couldn't find it. This will be very helpful! |
It should now be fixed. Problem was that I set the base path for the bash scrips as being in the vscode-extension folder, but the upload-artefact action didn't use that base path implicitly like the bash scripts did. Link to artifacts: https://github.com/sharkdp/numbat/actions/runs/12680011071?pr=659 I have tested the action artifact extension and it worked as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
No description provided.