memoize and change one case to default

sharmalab · Oct 10, 2024 · 2dc5f5c · 2dc5f5c
1 parent cb081c2
commit 2dc5f5c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/source/components/Layout/VisGridView/VisGridSplitter.js b/source/components/Layout/VisGridView/VisGridSplitter.js
@@ -9,7 +9,7 @@ const VisGridSplitter = ({ layout, size, fullVisScreenHandler, fullScreened }) =
 
   const renderSingleView = () => (
     <div className="vis-grid-splitter single">
-      <VisGridView fullVisScreenHandler={fullVisScreenHandler} designation="*" fullScreened={fullScreened} />
+      <VisGridView fullVisScreenHandler={fullVisScreenHandler} designation="default" fullScreened={fullScreened} />
     </div>
   );
 

diff --git a/source/components/Layout/VisGridView/VisGridView.js b/source/components/Layout/VisGridView/VisGridView.js
@@ -1,5 +1,5 @@
 import React, {
-  useState, useRef, useEffect, useContext,
+  useState, useRef, useEffect, useContext, useMemo,
 } from 'react';
 import { debounce } from 'lodash';
 import GridLayout from 'react-grid-layout';
@@ -29,10 +29,9 @@ function VisGridView({ fullVisScreenHandler, fullScreened, designation }) {
   });
   const self = useRef();
 
-  let visConfig = AllVisConfig.filter((x)=>{
-    return x.designation == designation
-    || (!x.designation && designation == "default")
-  });
+  const visConfig = useMemo(() => {
+    return AllVisConfig.filter((x) => x.designation === designation || (!x.designation && designation === "default"));
+  }, [AllVisConfig, designation]);
 
   const updateViewSize = () => {
     const rect = self.current.getBoundingClientRect();
@@ -66,13 +65,14 @@ function VisGridView({ fullVisScreenHandler, fullScreened, designation }) {
     SetIsResizing(false);
     SetResizingItemId(null);
   };
+
   useEffect(() => {
     updateViewSize();
     window.addEventListener('resize', debouncedUpdateViewSize);
     return () => {
       window.removeEventListener('resize', debouncedUpdateViewSize);
     };
-  }, [appLayout.currentCols, config.UNIT_OF_GRID_VIEW, config.UNIT_OF_GRID_VIEW, visConfig]);
+  }, [appLayout.currentCols, config.UNIT_OF_GRID_VIEW, visConfig]);
 
   useEffect(() => {
     const rect = self.current.getBoundingClientRect();