Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs to filtering #489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

fgvieira
Copy link

Add log info on filtered sequences

@shenwei356
Copy link
Owner

Thanks for this PR, but I think there's no need to log all removed sequences, as they would be a lot. Also, to be consistent with previous quiet behaviour, outputting such a lot extra logs should be optional with some flags like (--verbose).

And if you do want to know which sequences are filtered out, you can use seqkit grep -v -f <(seqkit seq -ni result.fx) input.fx | seqkit seq -ni to get the list.

@fgvieira
Copy link
Author

I agree, but I thought that the idea was to be verbose by default and, if not, the user could specify the --quiet option.

@shenwei356
Copy link
Owner

seqkit seq -m is frequently used, it's better not to freak users out with tens or hundreds of log info when they (including me) use previous commands (without --quiet) as usual.

I prefer outputting these logs optional with a new flag --verbose just for seqkit seq.

@fgvieira
Copy link
Author

Sure, that would work also. thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants