Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deb image #105

Closed
wants to merge 1 commit into from
Closed

Fix deb image #105

wants to merge 1 commit into from

Conversation

Caleb9
Copy link

@Caleb9 Caleb9 commented Sep 28, 2024

The image in deb directory doesn't build currently because the link to download has changed. This PR fixes the link.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@simonfelding
Copy link
Collaborator

@Caleb9 is this still an issue? Either way, I think the deb version is going to be pointless soon.

@Caleb9
Copy link
Author

Caleb9 commented Feb 15, 2025

@simonfelding I think it is, the URL for downloading the package has changed and the old one doesn't work.

Can you please elaborate on why is it going to be pointless soon? I'm building the image myself and always use the deb version. 🤔

edit:
Sorry, I stand corrected. I just checked and now both URLs work. You're welcome to close the PR. Thanks.

@simonfelding
Copy link
Collaborator

Hey @Caleb9, thank you so much for checking and confirming that both urls work!

The reason I think the deb build will be obsolete is that it only really exists because the build version was broken for so long. Now that the build is fixed, the deb version is going to be the same, but with less features.

For example I'm planning to make the protonmail config file editable, but that won't work for the deb version because it doesn't come with the utility to edit the config. There's going to be no reason to using it as it will work the same but be harder to configure 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants