Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

転送フィルターにバージョンとメタデータを追加する #123

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

miosakuma
Copy link
Contributor

Sora 2023.2.0 への追従で転送フィルターにバージョンとメタデータを追加しました。
あわせて Sora の仕様に合わせて action をオプション項目に追加しました。

sora-android-sdk-quickstart に以下のようなコードを追加して、未指定時に送信されないこと、指定時に送信されることを確認しています。

        val filter = SoraForwardingFilterOption(
            // action = SoraForwardingFilterOption.Action.BLOCK,
            rules =
            listOf(
                listOf(
                    SoraForwardingFilterOption.Rule(
                        SoraForwardingFilterOption.Rule.Field.CLIENT_ID,
                        SoraForwardingFilterOption.Rule.Operator.IS_IN,
                        listOf("screen-share")
                    ),
                    SoraForwardingFilterOption.Rule(
                        SoraForwardingFilterOption.Rule.Field.KIND,
                        SoraForwardingFilterOption.Rule.Operator.IS_IN,
                        listOf("audio")
                    )
                )
            ),
            version = "client",
            // metadata = mapOf("spam" to mapOf("egg" to "bacon"))
        )
        mediaChannel = SoraMediaChannel(
            context = this,
            signalingEndpoint = BuildConfig.SIGNALING_ENDPOINT,
            channelId = BuildConfig.CHANNEL_ID,
            signalingMetadata = Gson().fromJson(BuildConfig.SIGNALING_METADATA, Map::class.java),
            mediaOption = option,
            listener = channelListener, forwardingFilterOption = filter
        )

@miosakuma miosakuma force-pushed the feature/add-forwarding-filter-version-metadata branch from 16c522b to b52626c Compare January 19, 2024 06:24
@miosakuma miosakuma force-pushed the feature/add-forwarding-filter-version-metadata branch from b52626c to 8b3e642 Compare January 19, 2024 06:28
@miosakuma miosakuma requested a review from enm10k January 19, 2024 06:30
Copy link
Contributor

@enm10k enm10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます

@miosakuma miosakuma merged commit e7a40ce into develop Jan 19, 2024
1 check passed
@miosakuma miosakuma deleted the feature/add-forwarding-filter-version-metadata branch January 19, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants