-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Gradle Plugin を 8.5.0 にアップグレード #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGES に追加の記載を依頼しましたが、細かい内容はコメントに書いてくれているので項目が 1 行あれば大丈夫です
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
対応ありがとうございました、また、私の環境でもビルドが行えました。
問題ありません。
buildFeatures { | ||
// AGP 8.0 からデフォルトで false になった | ||
// このオプションが true でないと、defaultConfig に含まれている | ||
// buidlConfigField オプションが無効になってしまうため、true に設定する |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo してる...
変更内容
com.android.tools.build:gradle
を 8.5.0 に上げるThis pull request includes several updates to the build configuration and dependencies for the Android project. The main changes involve upgrading the Android Gradle Plugin, updating the Gradle version, and modifying build scripts to accommodate these upgrades.
Build Configuration Updates:
Java Version Update: Changed the Java version from 18 to 17 in the GitHub Actions workflow to align with the default JDK version of Android Gradle Plugin 8.5 and its long-term support. (
.github/workflows/build.yml
)Gradle Version Update: Updated the Gradle distribution URL from version 7.6.1 to 8.7 in the
gradle-wrapper.properties
file. (gradle/wrapper/gradle-wrapper.properties
)JDK Version for JitPack: Updated the JDK version from OpenJDK 11 to OpenJDK 17 in the
jitpack.yml
file. (jitpack.yml
)Android Project Configuration:
Android SDK Versions Update: Updated
compileSdkVersion
andtargetSdkVersion
from 32 to 34 in thebuild.gradle
file. (sora-android-sdk/build.gradle
)Build Script Adjustments:
compileOptions
frombuildTypes
to theandroid
block.classifier
witharchiveClassifier
in thesourcesJar
task.namespace
to theandroid
block as required by AGP 8.0. (sora-android-sdk/build.gradle
) [1] [2]package
attribute from the Android manifest file. (sora-android-sdk/src/main/AndroidManifest.xml
)Documentation:
CHANGES.md
documenting the upgrade to Android Gradle Plugin 8.5.0, including changes to Gradle, build script adjustments, and JDK version updates for GitHub Actions and JitPack. (CHANGES.md
)