-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaleResolutionDownTo を追加する #144
Merged
zztkm
merged 10 commits into
develop
from
feature/simulcast-encodings-scale-resolution-down-to
Jan 30, 2025
Merged
scaleResolutionDownTo を追加する #144
zztkm
merged 10 commits into
develop
from
feature/simulcast-encodings-scale-resolution-down-to
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
このあたりも関連しそうです。 sora-android-sdk/sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/rtc/PeerChannel.kt Line 376 in a9aa0a9
|
miosakuma
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 つコメントしましたがあとは大丈夫です
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scaleResolutionDownTo
を追加するThis pull request includes updates to the
sora-android-sdk
to add new functionality for video encoding parameters and some minor improvements to the codebase. The most important changes are as follows:New Functionality
scaleResolutionDownTo
parameter to theEncoding
data class to support simulating video encoding parameters. (sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/signaling/message/Catalog.kt
)PeerChannelImpl
class to utilize the newscaleResolutionDownTo
parameter. (sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/rtc/PeerChannel.kt
)Documentation
CHANGES.md
to reflect the addition of thescaleResolutionDownTo
parameter. (CHANGES.md
)Codebase Improvements
org.webrtc.RtpParameters
inCatalog.kt
to support the newscaleResolutionDownTo
parameter. (sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/signaling/message/Catalog.kt
)