Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaleResolutionDownTo を追加する #144

Merged
merged 10 commits into from
Jan 30, 2025

Conversation

zztkm
Copy link
Contributor

@zztkm zztkm commented Dec 19, 2024

  • [ADD] サイマルキャストの映像のエンコーディングパラメーター scaleResolutionDownTo を追加する

This pull request includes updates to the sora-android-sdk to add new functionality for video encoding parameters and some minor improvements to the codebase. The most important changes are as follows:

New Functionality

  • Added scaleResolutionDownTo parameter to the Encoding data class to support simulating video encoding parameters. (sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/signaling/message/Catalog.kt)
  • Updated the PeerChannelImpl class to utilize the new scaleResolutionDownTo parameter. (sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/rtc/PeerChannel.kt)

Documentation

  • Updated CHANGES.md to reflect the addition of the scaleResolutionDownTo parameter. (CHANGES.md)

Codebase Improvements

  • Imported org.webrtc.RtpParameters in Catalog.kt to support the new scaleResolutionDownTo parameter. (sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/signaling/message/Catalog.kt)

@zztkm zztkm changed the title WIP: scaleResolutionDownTo を追加する scaleResolutionDownTo を追加する Dec 19, 2024
@miosakuma
Copy link
Contributor

このあたりも関連しそうです。

private fun updateSenderOfferEncodings(sender: RtpSender) {

@zztkm zztkm changed the title scaleResolutionDownTo を追加する [WIP] scaleResolutionDownTo を追加する Jan 30, 2025
@zztkm zztkm changed the title [WIP] scaleResolutionDownTo を追加する scaleResolutionDownTo を追加する Jan 30, 2025
@zztkm zztkm requested a review from miosakuma January 30, 2025 03:41
@zztkm zztkm self-assigned this Jan 30, 2025
@miosakuma
Copy link
Contributor

Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 つコメントしましたがあとは大丈夫です

@zztkm zztkm merged commit 21de4dd into develop Jan 30, 2025
1 check passed
@zztkm zztkm deleted the feature/simulcast-encodings-scale-resolution-down-to branch January 30, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants