connect メッセージの multistream 送信仕様の変更 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
miosakuma
reviewed
Jan 28, 2025
| @@ -502,7 +502,7 @@ class SoraMediaChannel @JvmOverloads constructor( | |||
|
|
|||
| override fun onAddRemoteStream(ms: MediaStream) { | |||
| SoraLogger.d(TAG, "[channel:$role] @peer:onAddRemoteStream msid=:${ms.id}, connectionId=$connectionId") | |||
| if (mediaOption.multistreamEnabled && connectionId != null && ms.id == connectionId) { | |||
| if (mediaOption.multistreamEnabled == true && connectionId != null && ms.id == connectionId) { | |||
There was a problem hiding this comment.
mediaOption.multistreamEnabled が null の時はこの分岐にはいるのでしょうか。入らない場合は、Sora のデフォルトはマルチストリームなので「mediaOption.multistreamEnabled が false ではない」という条件にした方が良いように思いました。
ここは自分自身のストリームが通知された時にイベントを発行させないようにする処理だと思いますが、実際に sora-android-quickstart で動作をさせたところ、自分自身のストリームが入った通知は来ませんでした。
予期せぬケースを想定しているのかもしれません。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multistreamを true 固定で送信する処理を削除する破壊的変更SoraMediaOption.enableSpotlightを実行したときに multistream を true にする処理を削除ConnectMessage初期化時に渡す multistream の値をSoraMediaOption.multistreamEnabledに変更SoraMediaOption.multistreamIsRequired利用しなくなったので削除SoraMediaOption.enableMultistreamを非推奨にするSoraMediaOptionにenableLegacyStreamを追加するThis pull request includes several changes to the
sora-android-sdkto improve the handling of multistream options and deprecate legacy features. The most important changes include removing the fixedmultistreamvalue, updating theSoraMediaOptionclass, and deprecating certain methods.Changes to multistream handling:
multistreamvalue from the connect message and modified the initialization to useSoraMediaOption.multistreamEnabledinstead. (CHANGES.md,sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/signaling/message/Catalog.kt,sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/signaling/message/MessageConverter.kt) [1] [2] [3]multistreamEnabledinSoraMediaOptionfrom a Boolean to a nullable Boolean to allow for more flexible handling. (sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/option/SoraMediaOption.kt)SoraMediaChannelto checkmultistreamEnabledagainsttrueexplicitly. (sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/SoraMediaChannel.kt)Deprecation of legacy features:
enableMultistreammethod and added a newenableLegacyStreammethod, which is also marked as deprecated from the start. (sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/option/SoraMediaOption.kt)multistreamIsRequiredproperty and associated logic fromSoraMediaOptionas it is no longer used. (sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/option/SoraMediaOption.kt)These changes aim to simplify the codebase and prepare for the upcoming deprecation of legacy stream features.