PHP baseline: fix path (#32)

* PhpBaselineHandler.php: fix path Add missing slash, because __DIR__ does not have a trailing slash unless it is the root directory, @see https://www.php.net/manual/en/language.constants.magic.php#constant.dir * Fix test --------- Co-authored-by: jmdelehaye <[email protected]>
shipmonk-rnd · Dec 31, 2024 · 3635758 · 3635758
1 parent 3a9107f
commit 3635758
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/Handler/PhpBaselineHandler.php b/src/Handler/PhpBaselineHandler.php
@@ -41,7 +41,7 @@ public function encodeBaseline(string $comment, array $errors, string $indent):
                 "\$ignoreErrors[] = [\n{$indent}'message' => %s,\n{$indent}'count' => %d,\n{$indent}'path' => __DIR__ . %s,\n];\n",
                 var_export($error['message'], true),
                 var_export($error['count'], true),
-                var_export($error['path'], true),
+                var_export('/' . $error['path'], true),
             );
         }
 

diff --git a/tests/Rule/data/baselines-php/another.identifier.php b/tests/Rule/data/baselines-php/another.identifier.php
@@ -6,7 +6,7 @@
 $ignoreErrors[] = [
     'message' => '#^Error to escape \'\\#$#',
     'count' => 1,
-    'path' => __DIR__ . '../app/config.php',
+    'path' => __DIR__ . '/../app/config.php',
 ];
 
 return ['parameters' => ['ignoreErrors' => $ignoreErrors]];
diff --git a/tests/Rule/data/baselines-php/missing-identifier.php b/tests/Rule/data/baselines-php/missing-identifier.php
@@ -6,7 +6,7 @@
 $ignoreErrors[] = [
     'message' => '#^Error 3$#',
     'count' => 1,
-    'path' => __DIR__ . '../app/index.php',
+    'path' => __DIR__ . '/../app/index.php',
 ];
 
 return ['parameters' => ['ignoreErrors' => $ignoreErrors]];
diff --git a/tests/Rule/data/baselines-php/sample.identifier.php b/tests/Rule/data/baselines-php/sample.identifier.php
@@ -6,7 +6,7 @@
 $ignoreErrors[] = [
     'message' => '#^Error simple$#',
     'count' => 1,
-    'path' => __DIR__ . '../app/file.php',
+    'path' => __DIR__ . '/../app/file.php',
 ];
 
 return ['parameters' => ['ignoreErrors' => $ignoreErrors]];