Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add createFile & cross-platform cache #20

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Conversation

thautwarm
Copy link
Contributor

The major change is adding a createFile dialogue that supports path completion.
I also modify some default settings (preview is alway true for opening directories, and false for files), to fit emacs behavior.
If you want to fix #19 without this PR, you might just reuse src/autocompletedInputBox.ts.

#18 should be well fixed by this merge.

0. add createFile (ctrl+x =)
1. autocompletionInputBox
2. allow create Files and make createDir async
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late response. Thank you for your contribution and it looks good to me!

@shirou shirou merged commit f772759 into shirou:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding createFileOrOpen option?
2 participants