Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-gen): error messages and merging patches #1447

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Nov 12, 2024

Description

  • improved error messages
  • improved merging overrides
  • sorting arrays, so always generated in the same order
  • regenerated schema files

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Nov 12, 2024 6:49pm
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Nov 12, 2024 6:49pm

Copy link

pkg-pr-new bot commented Nov 12, 2024

Open in Stackblitz

@shopware/api-client

pnpm add https://pkg.pr.new/shopware/frontends/@shopware/api-client@1447

@shopware/api-gen

pnpm add https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1447

@shopware-pwa/cms-base

pnpm add https://pkg.pr.new/shopware/frontends/@shopware-pwa/cms-base@1447

@shopware-pwa/composables-next

pnpm add https://pkg.pr.new/shopware/frontends/@shopware-pwa/composables-next@1447

@shopware-pwa/helpers-next

pnpm add https://pkg.pr.new/shopware/frontends/@shopware-pwa/helpers-next@1447

@shopware-pwa/nuxt3-module

pnpm add https://pkg.pr.new/shopware/frontends/@shopware-pwa/nuxt3-module@1447

commit: b70b8ef

Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #1447 will not alter performance

Comparing fix/improve-error-messages (b70b8ef) with main (938c4cf)

Summary

✅ 9 untouched benchmarks

@patzick patzick merged commit 11ea41f into main Nov 13, 2024
13 checks passed
@patzick patzick deleted the fix/improve-error-messages branch November 13, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants