Add configuration tutorial #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
reviewed
Aug 28, 2024
| @@ -0,0 +1,140 @@ | |||
| # Shopware OpenTelemetry configuration | |||
There was a problem hiding this comment.
Gaitholabi
reviewed
Aug 29, 2024
Comment on lines
+38
to
+40
| main: | ||
| type: service | ||
| id: monolog.handler.open_telemetry |
There was a problem hiding this comment.
should this be documented to be used as a separate handler? rather than main?
Gaitholabi
reviewed
Aug 29, 2024
Comment on lines
+29
to
+33
| # traces | ||
| shopware: | ||
| profiler: | ||
| integrations: | ||
| - OpenTelemetry |
There was a problem hiding this comment.
Might be worth mentioning that this setting is only relevant for using the Profiler, not the auto tracing in general.
Auto tracing would be working directly after requiring the dependency via composer, without any configuration updates (besides the env vars).
Gaitholabi
reviewed
Aug 29, 2024
| OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE="delta" | ||
|
|
||
| # Attributes detectors | ||
| OTEL_PHP_DETECTORS="env" |
There was a problem hiding this comment.
would be worth saying, that this is the minimal set to make things work. (not setting it at all should also work).
or set a link to the full configuration set
h1k3r
force-pushed
the
improve-documentation
branch
from
ee43263 to
547058f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.