Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make scroll position in sidebar stable between client side navigation #4296

Merged
merged 11 commits into from
Mar 3, 2025

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Feb 28, 2025

regression from Nextra 3

fixes #64

Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: 82f0c49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra-theme-docs Patch
nextra Patch
nextra-theme-blog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:58am
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Mar 3, 2025 10:58am

Copy link
Contributor

github-actions bot commented Feb 28, 2025

📦 Next.js Bundle Analysis for swr-site

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 79.11 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link
Contributor

github-actions bot commented Feb 28, 2025

📦 Next.js Bundle Analysis for docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@dimaMachina dimaMachina marked this pull request as draft February 28, 2025 18:31
@dimaMachina dimaMachina marked this pull request as ready for review March 3, 2025 09:14
@dimaMachina dimaMachina changed the title fix: sidebar is scrolled on client side navigation fix: make scroll position in sidebar stable between client side navigation Mar 3, 2025
@dimaMachina dimaMachina merged commit fd4e6d1 into main Mar 3, 2025
9 checks passed
@dimaMachina dimaMachina deleted the v4-144 branch March 3, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure the sidebar layout is stable when navigating
1 participant