-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adjust gitlab_domains doc and support more cases
Issue #49 showed a mismatch between the docs the full SSH url. We can both update the docs and catch more cases. The issue with #49 was that we weren't allowing the user@ part of the domain. Whilst at the same time, the docs suggested having ssh:// in the options when really we just need the domain with no schema, port or user. This adjusts both that use case and the README
- Loading branch information
Showing
4 changed files
with
12 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#!/usr/bin/env bash | ||
|
||
docker build -f test/Dockerfile -t fugitive_gitlab . | ||
docker build -f test/Dockerfile -t fugitive_gitlab --load . | ||
|
||
docker run --rm -v `pwd`:/test/fugitive-gitlab.vim -w '/test' fugitive_gitlab vim -Es -Nu vimrc -c 'Vader! fugitive-gitlab.vim/test/*' > /dev/null | ||
docker run --rm -v `pwd`:/test/fugitive-gitlab.vim -w '/test' fugitive_gitlab nvim -Es -Nu vimrc -c 'Vader! fugitive-gitlab.vim/test/*' > /dev/null |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -109,3 +109,11 @@ Execute (gitlab#fugitive#homepage_for_remote - simple dict config with insecure | |
let expected = 'http://my.gitlab.com/shumphrey/fugitive-gitlab.vim' | ||
let url = gitlab#fugitive#homepage_for_remote('[email protected]:shumphrey/fugitive-gitlab.vim.git') | ||
AssertEqual url, expected | ||
|
||
Execute (gitlab#fugitive#homepage_for_remote - verbose ssh:// with user and port): | ||
let g:fugitive_gitlab_domains = { | ||
\ 'ssh://[email protected]:12345': 'https://my.gitlab.com:3456', | ||
\ } | ||
let expected = 'https://my.gitlab.com:3456/shumphrey/fugitive-gitlab.vim' | ||
let url = gitlab#fugitive#homepage_for_remote('ssh://[email protected]:12345/shumphrey/fugitive-gitlab.vim.git') | ||
AssertEqual url, expected |