#102 into [email protected] 🐘 add logger support #131

RiceWithMeat · 2023-11-21T11:27:11Z

Resolves #102

# Conflicts: # src/core/graphql/createGraphQLRoutes/createGraphQLRoutes.test.ts # src/core/graphql/createGraphQLRoutes/createGraphQLRoutes.ts # src/core/middlewares/notFoundMiddleware/notFoundMiddleware.test.ts # src/core/rest/createRestRoutes/createRestRoutes.test.ts # src/core/rest/createRestRoutes/createRestRoutes.ts # src/server/createGraphQLMockServer/createGraphQLMockServer.ts # src/server/createMockServer/createMockServer.ts # src/server/createRestMockServer/createRestMockServer.ts

…, update logger logic in createGraphQLRoutes

src/utils/types/logger.ts

src/utils/helpers/logger/helpers/coloredString/getRestMethodColoredString.ts

src/utils/helpers/logger/callRequestLogger/callRequestLogger.ts

src/utils/helpers/date/formatUnixTimestamp/formatUnixTimestamp.ts

.eslintrc.js

src/core/middlewares/requestInfoMiddleware/requestInfoMiddleware.ts

src/core/rest/createRestRoutes/createRestRoutes.ts

src/utils/types/logger.ts

src/utils/helpers/logger/helpers/formatLogMessage.ts

src/utils/helpers/logger/callResponseLogger/callResponseLogger.ts

MiaInturi · 2023-12-12T14:41:10Z

src/core/middlewares/requestInfoMiddleware/requestInfoMiddleware.ts

+    const isValidGraphQLRequest =
+      graphQLInput &&
+      graphQLInput.query &&
+      graphQLQuery?.operationType &&
+      graphQLQuery.operationName;
+    request.graphQL = isValidGraphQLRequest
+      ? {
+          operationType: graphQLQuery.operationType as GraphQLOperationType,
+          operationName: graphQLQuery.operationName,
+          variables: graphQLInput.variables
+        }
+      : null;


operationType и operationName в типе ResponseLogFunctionParams могут быть undefined, хотя по сути не могут

почему не могут? request.graphQL?.operationType будет undefined т.к. graphQL === null

src/core/middlewares/notFoundMiddleware/notFoundMiddleware.ts

src/static/views/features/scheme/index.js

# Conflicts: # .eslintrc.js # src/core/graphql/createGraphQLRoutes/createGraphQLRoutes.ts # src/core/middlewares/notFoundMiddleware/notFoundMiddleware.ts # src/core/rest/createRestRoutes/createRestRoutes.ts # src/server/createGraphQLMockServer/createGraphQLMockServer.ts # src/server/createMockServer/createMockServer.ts # src/server/createRestMockServer/createRestMockServer.ts # src/utils/helpers/interceptors/callRequestInterceptor/callRequestInterceptor.test.ts # src/utils/types/graphql.ts # src/utils/types/rest.ts # src/utils/types/utils.ts

bin/run.ts

src/utils/types/values.ts

src/utils/types/server.ts

src/utils/types/logger.ts

src/core/middlewares/notFoundMiddleware/notFoundMiddleware.ts

.eslintrc.js

src/utils/helpers/logger/callResponseLogger/callResponseLogger.ts

src/utils/types/logger.ts

… add rewrite function

src/utils/helpers/logger/callRequestLogger/callRequestLogger.test.ts

README.md

…leware refactoring fix readme, add callResponseLogger tests, add statusCode in default response log

src/utils/helpers/logger/index.ts

src/core/middlewares/contextMiddleware/contextMiddleware.ts

src/utils/helpers/logger/callRequestLogger/callRequestLogger.ts

src/utils/helpers/logger/helpers/filterTokenValues/filterTokenValues.ts

src/utils/helpers/logger/callResponseLogger/callResponseLogger.ts

src/utils/helpers/logger/helpers/filterTokenValues/filterTokenValues.ts

src/utils/types/logger.ts

src/utils/types/interceptors.ts

README.md

src/utils/helpers/logger/callResponseLogger/callResponseLogger.ts

… and graphql interceptors, replace (.mock.calls.length).toBe() -> .toBeCalledTimes(), fix readme

src/utils/helpers/logger/callResponseLogger/callResponseLogger.test.ts

src/utils/helpers/logger/callRequestLogger/callRequestLogger.test.ts

src/utils/helpers/logger/callResponseLogger/callResponseLogger.ts

…fix readme

…Options

src/utils/types/interceptors.ts

src/utils/types/logger.ts

MiaInturi · 2025-01-05T10:14:39Z

src/utils/helpers/logger/helpers/filterTokens/filterTokens.ts

+            if (objectTokenOption) {
+              acc[objectTokenName] = objectTokenValues[objectTokenName];
+            }


Может быть так, что body - это примитив, и тогда здесь код упадет

если body будет примитивом, то мы же только один раз достанем из него ключ и он будет undefined. я код не смог сломать. Но на всякий добавил проверку, чтобы actual token тоже был объектом. мало ли потом стрельнет когда body будем глубоко логать

src/utils/helpers/logger/helpers/filterTokens/filterTokens.ts

src/utils/helpers/logger/helpers/filterTokens/filterTokens.test.ts

README.md

…ResponseInterceptor type

README.md

src/utils/helpers/logger/helpers/filterTokens/filterTokens.ts

README.md

MiaInturi · 2025-01-05T12:34:11Z

src/utils/helpers/logger/helpers/filterTokens/filterTokens.ts

+      const tokenObjectOptionsFilterMode = resolveTokenObjectOptionsFilterMode(option);
+
+      if (tokenObjectOptionsFilterMode === 'whitelist') {
+        acc[name] = Object.entries(option).reduce((acc, [name, objectTokenOption]) => {


objectTokenOption

А почему везде ушла приписка token, а тут осталась?

Мб назвать тогда nestedOption? Раз сверху название просто option

поправил

согл

MiaInturi · 2025-01-05T12:34:47Z

src/utils/helpers/logger/helpers/filterTokens/filterTokens.ts

После этого я еще больше стал топить за no-shadow)))

если ты про параметр name, то хз как его обозвать. это не nestedOptionName потому что name есть только у токенов и не nestedTokenName потому что nested может быть только option, а не токен

RiceWithMeat added 3 commits November 19, 2023 21:25

#102 🐘 logger WIP

155955e

#102 🐘 logger WIP

da5e3f0

RiceWithMeat added the enhancement New feature or request label Nov 21, 2023

RiceWithMeat requested review from MiaInturi, anv296 and debabin November 21, 2023 11:27

RiceWithMeat self-assigned this Nov 21, 2023

#102 🐘 add logger in createRestMockServer and createGraphQLMockServer…

105cced

…, update logger logic in createGraphQLRoutes

RiceWithMeat linked an issue Nov 22, 2023 that may be closed by this pull request

Logger for rest and graphl routes #102

Closed

#102 🐘 loggers rework

1251aed

RiceWithMeat commented Dec 3, 2023

View reviewed changes

src/utils/types/logger.ts Outdated Show resolved Hide resolved

src/utils/helpers/logger/helpers/coloredString/getRestMethodColoredString.ts Outdated Show resolved Hide resolved

anv296 reviewed Dec 10, 2023

View reviewed changes

src/utils/helpers/logger/callRequestLogger/callRequestLogger.ts Outdated Show resolved Hide resolved

MiaInturi requested changes Dec 12, 2023

View reviewed changes

RiceWithMeat added 2 commits April 7, 2024 03:00

#102 🐘 logger rework

c427ea0

RiceWithMeat changed the base branch from [email protected] to [email protected] April 6, 2024 20:33

RiceWithMeat changed the title ~~#102 into [email protected] 🐘 add logger support~~ #102 into [email protected] 🐘 add logger support Apr 6, 2024

MiaInturi requested changes Jun 2, 2024

View reviewed changes

MiaInturi added the [email protected] label Jul 1, 2024

Merge remote-tracking branch 'refs/remotes/origin/main' into #102

3f7ce6d

RiceWithMeat changed the base branch from [email protected] to [email protected] November 11, 2024 13:42

RiceWithMeat changed the title ~~#102 into [email protected] 🐘 add logger support~~ #102 into [email protected] 🐘 add logger support Nov 11, 2024

RiceWithMeat added 5 commits November 12, 2024 03:01

#102 🐘 another logger rework

95a29c1

#102 🐘 simplify logger logic, add log function in interceptor params,…

8f51139

… add rewrite function

#102 🐘 remove loggers field in configs, rework filterTokenValues helper

2973218

#102 🐘 add tests, add readme, move formatTokenValues into helper

219b847

#102 🐘 fix types in readme

87367e4

RiceWithMeat marked this pull request as ready for review December 20, 2024 19:29

RiceWithMeat commented Dec 21, 2024

View reviewed changes

src/utils/helpers/logger/callRequestLogger/callRequestLogger.test.ts Outdated Show resolved Hide resolved

src/utils/helpers/logger/callRequestLogger/callRequestLogger.test.ts Show resolved Hide resolved

README.md Show resolved Hide resolved

RiceWithMeat changed the base branch from [email protected] to [email protected] December 22, 2024 09:55

RiceWithMeat changed the title ~~#102 into [email protected] 🐘 add logger support~~ #102 into [email protected] 🐘 add logger support Dec 22, 2024

RiceWithMeat added 2 commits December 22, 2024 19:46

#102 🐘 rename requestInfoMiddleware -> contextMiddleware, contextMidd…

ac14df2

…leware refactoring fix readme, add callResponseLogger tests, add statusCode in default response log

#102 🐘 remove useless type

ae46d1d

debabin reviewed Dec 23, 2024

View reviewed changes

RiceWithMeat added 2 commits December 23, 2024 23:34

#102 🐘 remove enabled flag for logger

3276961

#102 🐘 remove enabled flag for logger in readme

33d52f5

MiaInturi requested changes Dec 26, 2024

View reviewed changes

debabin reviewed Dec 26, 2024

View reviewed changes

src/utils/helpers/logger/callResponseLogger/callResponseLogger.ts Outdated Show resolved Hide resolved

#102 🐘 simplify logger types, allow use graphql tokens only in global…

dc32ec2

… and graphql interceptors, replace (.mock.calls.length).toBe() -> .toBeCalledTimes(), fix readme

debabin reviewed Jan 2, 2025

View reviewed changes

RiceWithMeat removed the [email protected] label Jan 3, 2025

RiceWithMeat added 3 commits January 3, 2025 22:49

#102 🐘 add graphQLQuery token, rename types and helpers

26275a2

#102 🐘 fix Interceptors type, remove logger object options for body, …

179e1fa

…fix readme

#102 🐘 rename type LoggerTokensToTokenOptions -> LoggerTokensToLogger…

98ec2e9

…Options

MiaInturi reviewed Jan 5, 2025

View reviewed changes

RiceWithMeat added 2 commits January 5, 2025 18:53

#102 🐘 fix readme and test for logger, swap Data and Api generics in …

6c501f4

…ResponseInterceptor type

#102 🐘 move spyOn for Date.now from test into describe

53ff177

debabin approved these changes Jan 5, 2025

View reviewed changes

#102 🐘 make tokens and rewrite optional in readme

02a09c0

MiaInturi requested changes Jan 5, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

#102 🐘 rename tokens parameter to options for log function

a0542c0

MiaInturi approved these changes Jan 5, 2025

View reviewed changes

#102 🐘 rename objectOptions -> nestedOption, fix comments in readme

1ab247e

RiceWithMeat merged commit 57205ea into [email protected] Jan 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#102 into [email protected] 🐘 add logger support #131

#102 into [email protected] 🐘 add logger support #131

RiceWithMeat commented Nov 21, 2023

MiaInturi Dec 12, 2023

RiceWithMeat Apr 6, 2024

MiaInturi Jan 5, 2025

RiceWithMeat Jan 5, 2025 •

edited

Loading

MiaInturi Jan 5, 2025

RiceWithMeat Jan 5, 2025

MiaInturi Jan 5, 2025

RiceWithMeat Jan 5, 2025

#102 into [email protected] 🐘 add logger support #131

#102 into [email protected] 🐘 add logger support #131

Conversation

RiceWithMeat commented Nov 21, 2023

MiaInturi Dec 12, 2023

Choose a reason for hiding this comment

RiceWithMeat Apr 6, 2024

Choose a reason for hiding this comment

MiaInturi Jan 5, 2025

Choose a reason for hiding this comment

RiceWithMeat Jan 5, 2025 • edited Loading

Choose a reason for hiding this comment

MiaInturi Jan 5, 2025

Choose a reason for hiding this comment

RiceWithMeat Jan 5, 2025

Choose a reason for hiding this comment

MiaInturi Jan 5, 2025

Choose a reason for hiding this comment

RiceWithMeat Jan 5, 2025

Choose a reason for hiding this comment

RiceWithMeat Jan 5, 2025 •

edited

Loading