-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GCP ccm #4513
feat: add GCP ccm #4513
Conversation
/approve |
fa4c673
to
40670e5
Compare
/m -ff |
you need first some reviews on the PR |
@rsmitty could be the best resource to review this one, I'm not familiar enough with this |
@frezbo Consider adding |
@nberlee Thanks for the feedback.
|
All possible settings are here: https://github.com/kubernetes/cloud-provider-gcp/blob/master/providers/gce/gce.go#L183
I must have been wrong about |
cloud-provider-gcp does not have many features than gce-ccm. If any one wants to run ccm without allocate-node-cidrs -- here fix sergelogvinov/cloud-provider-gcp@49216c9 (good for multi cloud setups) in my case, I use only that params, (csi/autoscale work fine with that ccm) command:
- /cloud-controller-manager
args:
- --bind-address=127.0.0.1
- --cloud-provider=gce
- --cloud-config=/etc/gce/gce.conf
- --allocate-node-cidrs=false
- --cluster-cidr=10.64.0.0/12
- --controllers=cloud-node,cloud-node-lifecycle
- --port=0
- --use-service-account-credentials
- -v=2 gce.conf: |
[global]
project-id =
network-name = |
1e8e21e
to
140f026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not an expert, but this looks much more fun to me
Update docs to reflect deploying GCP Cloud Control Manager (CCM) Signed-off-by: Noel Georgi <[email protected]>
/m -ff |
Update docs to reflect deploying GCP Cloud Control Manager (CCM)
Signed-off-by: Noel Georgi [email protected]
This change is